Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) producer to consumer should be multimap in cte #39850

Merged
merged 1 commit into from
Aug 23, 2024
Merged

[fix](Nereids) producer to consumer should be multimap in cte #39850

merged 1 commit into from
Aug 23, 2024

Conversation

morrySnow
Copy link
Contributor

because consumer could refer multi times for one producer' slot, so producer to consumer slot map should be multimap

@morrySnow
[fix](Nereids) producer to consumer should be multimap in cte
f1d0a45 
because consumer could refer multi times for one producer' slot, so
producer to consumer slot map should be multimap
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 38092 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f1d0a4513cbeb8e1096531dbf230757abfe8837b, data reload: false

------ Round 1 ----------------------------------
q1	17828	4428	4285	4285
q2	2039	191	177	177
q3	11867	975	1083	975
q4	10496	705	700	700
q5	7749	2819	2846	2819
q6	223	138	140	138
q7	969	614	599	599
q8	9340	2075	2092	2075
q9	6990	6518	6551	6518
q10	6998	2208	2259	2208
q11	445	241	244	241
q12	394	219	232	219
q13	17769	3040	3032	3032
q14	275	240	241	240
q15	523	482	483	482
q16	503	394	379	379
q17	986	729	702	702
q18	7539	6869	6924	6869
q19	1391	1021	969	969
q20	669	332	337	332
q21	4014	3243	3104	3104
q22	1122	1029	1068	1029
Total cold run time: 110129 ms
Total hot run time: 38092 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4365	4311	4280	4280
q2	378	268	268	268
q3	2900	2656	2683	2656
q4	1932	1646	1681	1646
q5	5588	5714	5705	5705
q6	239	141	138	138
q7	2269	1841	1799	1799
q8	3302	3466	3462	3462
q9	8802	8827	8829	8827
q10	3553	3394	3384	3384
q11	613	538	516	516
q12	816	679	704	679
q13	15473	3125	3207	3125
q14	337	285	296	285
q15	545	516	490	490
q16	483	446	453	446
q17	1835	1546	1557	1546
q18	8157	7775	7823	7775
q19	1748	1535	1519	1519
q20	2158	1909	1900	1900
q21	5683	5629	5524	5524
q22	1155	1055	1049	1049
Total cold run time: 72331 ms
Total hot run time: 57019 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191977 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f1d0a4513cbeb8e1096531dbf230757abfe8837b, data reload: false

query1	1256	883	859	859
query2	6356	1856	1842	1842
query3	10788	4146	3958	3958
query4	60313	24142	23081	23081
query5	5361	502	502	502
query6	406	160	170	160
query7	5759	292	295	292
query8	287	203	190	190
query9	9009	2497	2494	2494
query10	488	274	264	264
query11	18003	15108	15262	15108
query12	163	117	103	103
query13	1572	381	393	381
query14	11123	7616	7497	7497
query15	223	184	173	173
query16	7540	489	476	476
query17	1127	569	576	569
query18	1945	308	297	297
query19	295	146	146	146
query20	119	111	116	111
query21	207	107	105	105
query22	4688	4546	4387	4387
query23	34523	33632	33491	33491
query24	5882	2821	2792	2792
query25	521	377	368	368
query26	679	158	156	156
query27	1772	288	274	274
query28	3866	2082	2060	2060
query29	669	398	410	398
query30	238	152	148	148
query31	910	737	721	721
query32	77	57	57	57
query33	494	285	285	285
query34	853	475	478	475
query35	840	702	693	693
query36	1059	928	963	928
query37	144	83	79	79
query38	4023	3908	3896	3896
query39	1475	1373	1391	1373
query40	201	115	124	115
query41	46	46	44	44
query42	115	96	99	96
query43	510	477	471	471
query44	1118	750	750	750
query45	199	166	162	162
query46	1093	722	742	722
query47	1896	1810	1837	1810
query48	368	279	286	279
query49	763	423	436	423
query50	806	407	428	407
query51	7046	7176	7003	7003
query52	95	89	90	89
query53	249	213	183	183
query54	552	441	448	441
query55	76	75	76	75
query56	279	257	244	244
query57	1192	1081	1080	1080
query58	212	216	220	216
query59	3020	2758	2738	2738
query60	292	264	257	257
query61	103	98	97	97
query62	775	645	666	645
query63	224	188	187	187
query64	3152	1823	1767	1767
query65	3185	3182	3170	3170
query66	674	336	329	329
query67	15430	15288	15204	15204
query68	2988	581	584	581
query69	410	273	272	272
query70	1180	1071	1137	1071
query71	345	276	273	273
query72	2609	2099	2038	2038
query73	708	324	322	322
query74	9126	8887	8894	8887
query75	3352	2758	2674	2674
query76	1390	1096	1006	1006
query77	572	389	322	322
query78	10020	9014	9081	9014
query79	1055	551	544	544
query80	673	508	516	508
query81	448	231	224	224
query82	299	141	135	135
query83	168	152	149	149
query84	249	82	72	72
query85	671	306	279	279
query86	306	310	303	303
query87	4367	4276	4369	4276
query88	3144	2284	2293	2284
query89	371	289	291	289
query90	2025	194	198	194
query91	124	125	161	125
query92	59	55	51	51
query93	1052	551	545	545
query94	690	307	305	305
query95	309	260	257	257
query96	591	267	270	267
query97	3201	3045	3069	3045
query98	220	218	197	197
query99	1501	1275	1309	1275
Total cold run time: 302947 ms
Total hot run time: 191977 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.88 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f1d0a4513cbeb8e1096531dbf230757abfe8837b, data reload: false

query1	0.05	0.05	0.04
query2	0.09	0.04	0.04
query3	0.23	0.04	0.05
query4	1.66	0.08	0.08
query5	0.49	0.54	0.48
query6	1.13	0.74	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.54	0.48	0.48
query10	0.53	0.52	0.52
query11	0.15	0.12	0.11
query12	0.15	0.12	0.13
query13	0.62	0.59	0.58
query14	0.77	0.79	0.78
query15	0.85	0.82	0.81
query16	0.37	0.38	0.36
query17	1.02	1.05	1.03
query18	0.21	0.21	0.20
query19	1.84	1.72	1.77
query20	0.01	0.02	0.01
query21	15.40	0.67	0.66
query22	3.68	7.64	1.93
query23	18.26	1.42	1.39
query24	2.16	0.24	0.23
query25	0.17	0.08	0.08
query26	0.26	0.18	0.18
query27	0.08	0.07	0.08
query28	13.15	1.02	1.00
query29	12.64	3.28	3.28
query30	0.24	0.06	0.05
query31	2.87	0.40	0.41
query32	3.22	0.48	0.47
query33	2.93	2.97	2.97
query34	17.17	4.45	4.51
query35	4.54	4.47	4.51
query36	0.65	0.47	0.49
query37	0.18	0.15	0.16
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.09	0.05	0.05
query42	0.07	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 108.95 s
Total hot run time: 30.88 s

@starocean999 starocean999 merged commit d3b48a4 into apache:master Aug 23, 2024
28 of 31 checks passed
@morrySnow morrySnow deleted the fix_cte_duplicate_column_failed branch August 23, 2024 12:42
morrySnow added a commit that referenced this pull request Aug 23, 2024
@morrySnow
[fix](Nereids) producer to consumer should be multimap in cte (#39850)
986006d 
pick from master #39850

because consumer could refer multi times for one producer' slot, so
producer to consumer slot map should be multimap
@morrySnow morrySnow mentioned this pull request Aug 23, 2024
Merged
morrySnow added a commit that referenced this pull request Aug 23, 2024
@morrySnow
[fix](Nereids) producer to consumer should be multimap in cte (#39850) (
9d597bd 
#39867)
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
Open
3 tasks
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Sep 9, 2024
@morrySnow
[fix](Nereids) producer to consumer should be multimap in cte (apache…
eb9dfdd 
…#39850)

pick from master apache#39850

because consumer could refer multi times for one producer' slot, so producer to consumer slot map should be multimap
@morrySnow morrySnow mentioned this pull request Sep 9, 2024
Merged
morrySnow added a commit that referenced this pull request Sep 9, 2024
@morrySnow
[fix](Nereids) producer to consumer should be multimap in cte (#39850) (
770e1fd 
#40544)

pick from master #39850

because consumer could refer multi times for one producer' slot, so
producer to consumer slot map should be multimap
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@morrySnow @dataroaring
[fix](Nereids) producer to consumer should be multimap in cte (#39850)
cc4aad5 
because consumer could refer multi times for one producer' slot, so
producer to consumer slot map should be multimap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@924060929 924060929 924060929 approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.15-merged dev/2.1.6-merged dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@morrySnow @doris-robot @924060929 @starocean999 @shuke987 @dataroaring